]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ext2: fix a block leak
authorAl Viro <viro@zeniv.linux.org.uk>
Thu, 17 May 2018 21:18:30 +0000 (17:18 -0400)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 14 Aug 2018 10:28:14 +0000 (12:28 +0200)
commit6f860762ae9c1d51e1cf7a2646a16ceaef4fb7ce
tree3ac2e39d452dc9805dcde2f9235b8c50de68fbaa
parent10451cc48d4429d7348575a03d0250f8f98c76c1
ext2: fix a block leak

BugLink: http://bugs.launchpad.net/bugs/1783418
commit 5aa1437d2d9a068c0334bd7c9dafa8ec4f97f13b upstream.

open file, unlink it, then use ioctl(2) to make it immutable or
append only.  Now close it and watch the blocks *not* freed...

Immutable/append-only checks belong in ->setattr().
Note: the bug is old and backport to anything prior to 737f2e93b972
("ext2: convert to use the new truncate convention") will need
these checks lifted into ext2_setattr().

Cc: stable@kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
fs/ext2/inode.c