]> git.proxmox.com Git - qemu.git/commit
scsi-disk: Move active request asserts
authorStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Fri, 12 Nov 2010 09:57:11 +0000 (09:57 +0000)
committerKevin Wolf <kwolf@redhat.com>
Wed, 24 Nov 2010 16:30:19 +0000 (17:30 +0100)
commit6fa2c95f279dda62aa7e3292cc424ff3fab6a602
tree75e8079858a8fb5ec6a809fd032a947911583cdc
parentf711df67d611e4762966a249742a5f7499e19f99
scsi-disk: Move active request asserts

SCSI read/write requests should not be re-issued before the current
fragment of I/O completes.  There are asserts in scsi-disk.c that guard
this constraint but they trigger on SPARC Linux 2.4.  It turns out that
the asserts are too early in the code path and don't allow for read
requests to terminate.

Only the read assert needs to be moved but move the write assert too for
consistency.

Reported-by: Nigel Horne <njh@bandsman.co.uk>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
hw/scsi-disk.c