]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
driver: base: fix UAF when driver_attach failed
authorSchspa Shi <schspa@gmail.com>
Fri, 13 May 2022 11:24:44 +0000 (19:24 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 26 Aug 2022 08:52:44 +0000 (10:52 +0200)
commit6fc9f5f519e7d9301240949ee128a4f7055e8dfa
tree02658d211afa53a1090df06ffba2838d201ead0a
parentd24948144d061989f881b9a1b4f96b7431755a7c
driver: base: fix UAF when driver_attach failed

BugLink: https://bugs.launchpad.net/bugs/1982968
[ Upstream commit 310862e574001a97ad02272bac0fd13f75f42a27 ]

When driver_attach(drv); failed, the driver_private will be freed.
But it has been added to the bus, which caused a UAF.

To fix it, we need to delete it from the bus when failed.

Fixes: 190888ac01d0 ("driver core: fix possible missing of device probe")
Signed-off-by: Schspa Shi <schspa@gmail.com>
Link: https://lore.kernel.org/r/20220513112444.45112-1-schspa@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/base/bus.c