]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
af_unix: Add dead flag to struct scm_fp_list.
authorKuniyuki Iwashima <kuniyu@amazon.com>
Wed, 8 May 2024 17:11:50 +0000 (10:11 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 11 May 2024 01:52:45 +0000 (18:52 -0700)
commit7172dc93d621d5dc302d007e95ddd1311ec64283
tree9dcbc685a20185bd292a3e7042c42da430bf310f
parent84c8b7ad5e748c0b93415b060c7071f8c524f4f5
af_unix: Add dead flag to struct scm_fp_list.

Commit 1af2dface5d2 ("af_unix: Don't access successor in unix_del_edges()
during GC.") fixed use-after-free by avoid accessing edge->successor while
GC is in progress.

However, there could be a small race window where another process could
call unix_del_edges() while gc_in_progress is true and __skb_queue_purge()
is on the way.

So, we need another marker for struct scm_fp_list which indicates if the
skb is garbage-collected.

This patch adds dead flag in struct scm_fp_list and set it true before
calling __skb_queue_purge().

Fixes: 1af2dface5d2 ("af_unix: Don't access successor in unix_del_edges() during GC.")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Link: https://lore.kernel.org/r/20240508171150.50601-1-kuniyu@amazon.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/scm.h
net/core/scm.c
net/unix/garbage.c