]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
pkcs7: fix check for self-signed certificate
authorEric Biggers <ebiggers@google.com>
Fri, 8 Dec 2017 15:13:28 +0000 (15:13 +0000)
committerDavid Howells <dhowells@redhat.com>
Fri, 8 Dec 2017 15:13:28 +0000 (15:13 +0000)
commit7204eb8590c750e8c10b47f4acd4efe6e4138452
treeb6e67acf18994b248f57d71d03dc872e9557a93a
parent8ecb506d3476aa58077e79ef1f75395625458fcc
pkcs7: fix check for self-signed certificate

pkcs7_validate_trust_one() used 'x509->next == x509' to identify a
self-signed certificate.  That's wrong; ->next is simply the link in the
linked list of certificates in the PKCS#7 message.  It should be
checking ->signer instead.  Fix it.

Fortunately this didn't actually matter because when we re-visited
'x509' on the next iteration via 'x509->signer', it was already seen and
not verified, so we returned -ENOKEY anyway.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: James Morris <james.l.morris@oracle.com>
crypto/asymmetric_keys/pkcs7_trust.c