]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
Char: mxser, globals cleanup
authorJiri Slaby <jirislaby@gmail.com>
Fri, 25 Jul 2008 08:48:20 +0000 (01:48 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 25 Jul 2008 17:53:43 +0000 (10:53 -0700)
commit72800df9ba3199df02a95b3830c49fbf16ec4a6d
tree0c51326b74d052134019735a3c0da76a13ae0068
parent41aee9a121fd0c31ae22dfe57e8f9ee9d6d85c25
Char: mxser, globals cleanup

- remove unused mxvar_diagflag
- move mxser_msr into the only user/function
- GMStatus, hmm, fix race-prone access to it. We need only one instance for
  real, not MXSER_PORTS. Move it to MOXA_GETMSTATUS ioctl.
- mxser_mon_ext, almost the same, but alloc it on heap, since it has more than
  2 kilos.
- fix indexing, `i' is not the index value, `i * MXSER_PORTS_PER_BOARD + j' is

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/mxser.c