]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
nvme-pci: Fix AER reset handling
authorKeith Busch <keith.busch@intel.com>
Thu, 24 May 2018 22:16:04 +0000 (16:16 -0600)
committerChristoph Hellwig <hch@lst.de>
Fri, 25 May 2018 14:50:12 +0000 (16:50 +0200)
commit72cd4cc28e234ed7189ee508ed65ab60c80a97c8
tree2a04fb6870ec3ad2d024dee14dd38e525a68077d
parenta8e3e0bb749c0893a2cfd24652a77f45eea338d3
nvme-pci: Fix AER reset handling

The nvme timeout handling doesn't do anything if the pci channel is
offline, which is the case when recovering from PCI error event, so it
was a bad idea to sync the controller reset in this state. This patch
flushes the reset work in the error_resume callback instead when the
channel is back to online. This keeps AER handling serialized and
can recover from timeouts.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=199757
Fixes: cc1d5e749a2e ("nvme/pci: Sync controller reset for AER slot_reset")
Reported-by: Alex Gagniuc <mr.nuke.me@gmail.com>
Tested-by: Alex Gagniuc <mr.nuke.me@gmail.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/pci.c