]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
team: move add to port list before port enablement
authorJiri Pirko <jiri@resnulli.us>
Sat, 8 Jun 2013 13:00:54 +0000 (15:00 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 12 Jun 2013 07:56:27 +0000 (00:56 -0700)
commit72df935d985c1575ed44ad2c8c653b28147993fa
treef542a207e79b8d9fda9edf98f384d49ca87db126
parent76c455decbbad31de21c727edb184a963f42b40b
team: move add to port list before port enablement

team_port_enable() adds port to port_hashlist. Reader sees port
in team_get_port_by_index_rcu() and returns it, but
team_get_first_port_txable_rcu() tries to go through port_list, where the
port is not inserted yet -> NULL pointer dereference.
Fix this by reordering port_list and port_hashlist insertion.
Panic is easily triggeable when txing packets and adding/removing port
in a loop.

Introduced by commit 3d249d4c "net: introduce ethernet teaming device"

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/team/team.c