]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
selinux: initialize proto variable in selinux_ip_postroute_compat()
authorTom Rix <trix@redhat.com>
Fri, 24 Dec 2021 15:07:39 +0000 (07:07 -0800)
committerPaul Moore <paul@paul-moore.com>
Mon, 27 Dec 2021 15:41:20 +0000 (10:41 -0500)
commit732bc2ff080c447f8524f40c970c481f5da6eed3
tree67fb464fe0aa6eeff99dd09d704089b9158627d2
parentcc274ae7763d9700a56659f3228641d7069e7a3f
selinux: initialize proto variable in selinux_ip_postroute_compat()

Clang static analysis reports this warning

hooks.c:5765:6: warning: 4th function call argument is an uninitialized
                value
        if (selinux_xfrm_postroute_last(sksec->sid, skb, &ad, proto))
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

selinux_parse_skb() can return ok without setting proto.  The later call
to selinux_xfrm_postroute_last() does an early check of proto and can
return ok if the garbage proto value matches.  So initialize proto.

Cc: stable@vger.kernel.org
Fixes: eef9b41622f2 ("selinux: cleanup selinux_xfrm_sock_rcv_skb() and selinux_xfrm_postroute_last()")
Signed-off-by: Tom Rix <trix@redhat.com>
[PM: typo/spelling and checkpatch.pl description fixes]
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/selinux/hooks.c