]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
isdn: hisax: hfc_pci: Fix a possible concurrency use-after-free bug in HFCPCI_l1hw()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 26 Dec 2018 14:09:34 +0000 (22:09 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 29 Dec 2018 05:27:31 +0000 (21:27 -0800)
commit7418e6520f22a2e35815122fa5a53d5bbfa2c10f
tree732d18013dc3e3eb26f1c5d2b9b9c9d541b8ed1c
parentf9fc54d313fab2834f44f516459cdc8ac91d797f
isdn: hisax: hfc_pci: Fix a possible concurrency use-after-free bug in HFCPCI_l1hw()

In drivers/isdn/hisax/hfc_pci.c, the functions hfcpci_interrupt() and
HFCPCI_l1hw() may be concurrently executed.

HFCPCI_l1hw()
  line 1173: if (!cs->tx_skb)

hfcpci_interrupt()
  line 942: spin_lock_irqsave();
  line 1066: dev_kfree_skb_irq(cs->tx_skb);

Thus, a possible concurrency use-after-free bug may occur
in HFCPCI_l1hw().

To fix these bugs, the calls to spin_lock_irqsave() and
spin_unlock_irqrestore() are added in HFCPCI_l1hw(), to protect the
access to cs->tx_skb.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hisax/hfc_pci.c