]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
bcm2835-v4l2: Fix buffer overflow problem
authorDave Stevenson <dave.stevenson@raspberrypi.org>
Fri, 10 Mar 2017 14:43:15 +0000 (14:43 +0000)
committerTim Gardner <tim.gardner@canonical.com>
Fri, 17 Mar 2017 15:54:36 +0000 (09:54 -0600)
commit744c60affe3dacf4ede6c04821a778e58890d484
treebd7cb37cbb2d341af6ced335a1bf2fe3f531cfea
parentc08334b3f3646276990c96f78790d48a2846ad37
bcm2835-v4l2: Fix buffer overflow problem

https://github.com/raspberrypi/linux/issues/1447
port_parameter_get() failed to account for the header
(u32 id and u32 size) in the size before memcpying
the response into the response buffer, so overrunning
the provided buffer by 8 bytes.

Account for those bytes, and also a belt-and-braces
check to ensure we never copy more than *value_size
bytes into value.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/media/platform/bcm2835/mmal-vchiq.c