]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
drm/i915: Apply batch location restrictions before pinning
authorChris Wilson <chris@chris-wilson.co.uk>
Sun, 10 Jun 2018 19:43:09 +0000 (20:43 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 11 Jun 2018 10:00:26 +0000 (11:00 +0100)
commit746c8f143afad7aaa66c484485fc39888d437a3f
tree44419d31a7f778a7daf5e8200182f1d591a86a21
parentacd1c1e621fcd90bf94e31b0c871cd241c9153ef
drm/i915: Apply batch location restrictions before pinning

We special case the position of the batch within the GTT to prevent
negative self-relocation deltas from underflowing. However, that
restriction is being applied after a trial pin of the batch in its
current position. Thus we are not rejecting an invalid location if the
batch has been used before, leading to an assertion if we happen to need
to rearrange the entire payload. In the worst case, this may cause a GPU
hang on gen7 or perhaps missing state.

References: https://bugs.freedesktop.org/show_bug.cgi?id=105720
Fixes: 2889caa92321 ("drm/i915: Eliminate lots of iterations over the execobjects array")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Martin Peres <martin.peres@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180610194325.13467-2-chris@chris-wilson.co.uk
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
drivers/gpu/drm/i915/i915_gem_execbuffer.c