]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
drm/msm: Fix NULL deref on bind/probe deferral
authorSean Paul <seanpaul@chromium.org>
Thu, 31 May 2018 18:48:58 +0000 (14:48 -0400)
committerRob Clark <robdclark@gmail.com>
Mon, 4 Jun 2018 16:50:42 +0000 (12:50 -0400)
commit74d3a3a70775de356b96b5461c3a204a51496fb3
tree40705c1662d17f938b5a9991d3524fcd6b03f8db
parentd14659f5de7d2822764d6944ce7d8d7570ebfd9b
drm/msm: Fix NULL deref on bind/probe deferral

This patch avoids dereferencing msm_host->dev when it is NULL.

If we find ourselves tearing down dsi before calling
(mdp4|mdp5|dpu)_kms_init(), we'll end up in a state where the dev
pointer is NULL and trying to extract priv from it will fail.

This was introduced in a seemingly innocuous commit to ensure the
arguments to msm_gem_put_iova() are correct (even though that
function has been a stub for ~5 years). Correctness FTW! \o/

Fixes: b01884a286b0 drm/msm: use correct aspace pointer in msm_gem_put_iova()
Cc: Daniel Mack <daniel@zonque.org>
Cc: Rob Clark <robdclark@gmail.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
drivers/gpu/drm/msm/dsi/dsi_host.c