]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
IB/srpt: Remove redundant assignment to ret
authorYang Li <yang.lee@linux.alibaba.com>
Thu, 6 May 2021 10:15:05 +0000 (18:15 +0800)
committerJason Gunthorpe <jgg@nvidia.com>
Tue, 11 May 2021 16:42:17 +0000 (13:42 -0300)
commit74ec2424737a9d5ffa6e4f957e57fb1baff19a5c
treecfc809978ace509aaa08dfc5d22874fcb9850ba5
parente6a1f8c696be3ed07b5f4ce81ce7c45f7ff9a483
IB/srpt: Remove redundant assignment to ret

Variable 'ret' is set to -ENOMEM but this value is never read as it is
overwritten with a new value later on, hence it is a redundant assignment
and can be removed

In 'commit b79fafac70fc ("target: make queue_tm_rsp() return void")'
srpt_queue_response() has been changed to return void, so after "goto
out", there is no need to return ret.

Clean up the following clang-analyzer warning:

drivers/infiniband/ulp/srpt/ib_srpt.c:2860:3: warning: Value stored to
'ret' is never read [clang-analyzer-deadcode.DeadStores]

Fixes: b99f8e4d7bcd ("IB/srpt: convert to the generic RDMA READ/WRITE API")
Link: https://lore.kernel.org/r/1620296105-121964-1-git-send-email-yang.lee@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/ulp/srpt/ib_srpt.c