]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
nvme-pci: fix surprise removal
authorIgor Konopko <igor.j.konopko@intel.com>
Fri, 23 Nov 2018 15:58:10 +0000 (16:58 +0100)
committerChristoph Hellwig <hch@lst.de>
Tue, 27 Nov 2018 17:12:26 +0000 (18:12 +0100)
commit751a0cc0cd3a0d51e6aaf6fd3b8bd31f4ecfaf3e
tree9d5785fda6ed4a7dae44d3ee897d6bec8f9ea7ab
parentdfa74422d604abc2e16763db12646583219806e4
nvme-pci: fix surprise removal

When a PCIe NVMe device is not present, nvme_dev_remove_admin() calls
blk_cleanup_queue() on the admin queue, which frees the hctx for that
queue.  Moments later, on the same path nvme_kill_queues() calls
blk_mq_unquiesce_queue() on admin queue and tries to access hctx of it,
which leads to following OOPS:

Oops: 0000 [#1] SMP PTI
RIP: 0010:sbitmap_any_bit_set+0xb/0x40
Call Trace:
 blk_mq_run_hw_queue+0xd5/0x150
 blk_mq_run_hw_queues+0x3a/0x50
 nvme_kill_queues+0x26/0x50
 nvme_remove_namespaces+0xb2/0xc0
 nvme_remove+0x60/0x140
 pci_device_remove+0x3b/0xb0

Fixes: cb4bfda62afa2 ("nvme-pci: fix hot removal during error handling")
Signed-off-by: Igor Konopko <igor.j.konopko@intel.com>
Reviewed-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/core.c