]> git.proxmox.com Git - pve-manager.git/commit
Enable "Discard" option for IDE and SATA drives
authorNick Chevsky <nchevsky@gmail.com>
Wed, 14 Nov 2018 04:42:05 +0000 (23:42 -0500)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 14 Nov 2018 08:21:12 +0000 (09:21 +0100)
commit75357e9f0d2328fec72eae3d0a91ffcfc405321b
tree2c06309e4718d61dc249787b31af0eec91fb8f33
parent793f2cf4e0871b5397d33f34a3096c02fac86578
Enable "Discard" option for IDE and SATA drives

Even though QEMU supports the discard feature for both ATA [1] and
SCSI drives, the "Discard" checkbox in Proxmox VE is artificially
restricted to SCSI drives. This change expands availability of the
"Discard" checkbox to all drive types supported by QEMU, leaving
VirtIO Block as the only remaining exclusion.

Combined with the new "SSD emulation" option [2], enabling discard
on IDE/SATA drives allows reclaiming of free space on thin-provisioned
storage with guests that do not support our SCSI controllers.

[1] https://github.com/qemu/qemu/commit/d353fb72f59cd0e1f67baf773e74719cda761a89
[2] https://git.proxmox.com/?p=pve-manager.git;a=commit;h=f9261fde2134cec35a5ec7c3ebbee5daa4d67ec7

Signed-off-by: Nick Chevsky <nchevsky@gmail.com>
Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
www/manager6/qemu/HDEdit.js