]> git.proxmox.com Git - ovs.git/commit
tests: Fix *bsd failure in OVS_APP_EXIT_AND_WAIT.
authorLance Richardson <lrichard@redhat.com>
Thu, 31 Mar 2016 13:52:22 +0000 (09:52 -0400)
committerBen Pfaff <blp@ovn.org>
Thu, 31 Mar 2016 14:53:18 +0000 (07:53 -0700)
commit7562379719a9cd42b79fcff3a6a288e5961cc561
treec789ed3eb15e4bb7f5301ae5333a0f6b9256e21e
parenta6be657b299369da9780b67fe2f11caf835e6355
tests: Fix *bsd failure in OVS_APP_EXIT_AND_WAIT.

When using the default user shell in FreeBSD and NetBSD and executing
a test in which the app name parameter to OVS_APP_EXIT_AND_WAIT
contains backticks (e.g. "`pwd`/unixctl"), TMPPID expands to:

    `cat "$OVS_RUNDIR"/"`pwd`"/unixctl.pid 2>/dev/null`

This results in an "unterminated quoted string" syntax error from
the shell.

Correct this by replacing backticks with $(...) in OVS_APP_EXIT_AND_WAIT.
Verified via "make check" under NetBSD 7 and Fedora 23.

Fixes: f9b11f2a09b4 ("tests: Make OVS_APP_EXIT_AND_WAIT() wait for process termination")
Reported-by: Aaron Conole <aconole@redhat.com>
Signed-off-by: Lance Richardson <lrichard@redhat.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
tests/ovs-macros.at