]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
ata: dwc: add DMADEVICES dependency
authorArnd Bergmann <arnd@arndb.de>
Wed, 11 May 2016 13:42:08 +0000 (15:42 +0200)
committerTejun Heo <tj@kernel.org>
Thu, 12 May 2016 16:04:13 +0000 (12:04 -0400)
commit7598469a6184e1017a77ebe78b5b66c52a6afc1c
tree7bd15507e6c83305e9ac566f1c4cd3fc19b0ebf6
parent951b8e4e673196932fa4c3b87d719644636e5ac9
ata: dwc: add DMADEVICES dependency

The dwc_460ex SATA driver has become available on non-powerpc architectures
and may cause randconfig build errors when CONFIG_DMADEVICES is not set
and SATA_DWC_OLD_DMA is enabled:

warning: (SATA_DWC_OLD_DMA) selects DW_DMAC_CORE which has unmet direct dependencies (DMADEVICES)
ERROR: "dw_dma_probe" [drivers/ata/sata_dwc_460ex.ko] undefined!
ERROR: "dw_dma_remove" [drivers/ata/sata_dwc_460ex.ko] undefined!

This adds an explcit Kconfig dependency to CONFIG_SATA_DWC so we
cannot run into broken configurations. While it would also be
possible to build the driver with both CONFIG_DMADEVICES
and SATA_DWC_OLD_DMA disabled, that case is not useful because
there is no fallback to PIO mode when the DMA engine is not
usable.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 50b433753df6 ("ata: sata_dwc_460ex: use "dmas" DT property to find dma channel")
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/Kconfig