]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid
authorDavid Edmondson <david.edmondson@oracle.com>
Thu, 18 Mar 2021 12:08:37 +0000 (12:08 +0000)
committerKelsey Skunberg <kelsey.skunberg@canonical.com>
Mon, 24 May 2021 23:46:40 +0000 (17:46 -0600)
commit75bc72f0876007c301d4e692d2e1034eaa23dfd1
treefbbbe7adc520630c8197ff9b0b3866136d9c17e0
parent783d6822471177d3a5241756bafb747392ba4a40
KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid

BugLink: https://bugs.launchpad.net/bugs/1929455
[ Upstream commit d9e46d344e62a0d56fd86a8289db5bed8a57c92e ]

If the VM entry/exit controls for loading/saving MSR_EFER are either
not available (an older processor or explicitly disabled) or not
used (host and guest values are the same), reading GUEST_IA32_EFER
from the VMCS returns an inaccurate value.

Because of this, in dump_vmcs() don't use GUEST_IA32_EFER to decide
whether to print the PDPTRs - always do so if the fields exist.

Fixes: 4eb64dce8d0a ("KVM: x86: dump VMCS on invalid entry")
Signed-off-by: David Edmondson <david.edmondson@oracle.com>
Message-Id: <20210318120841.133123-2-david.edmondson@oracle.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
arch/x86/kvm/vmx/vmx.c