]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
mailbox: mpfs: fix an incorrect mask width
authorConor Dooley <conor.dooley@microchip.com>
Tue, 7 Mar 2023 20:22:51 +0000 (20:22 +0000)
committerConor Dooley <conor.dooley@microchip.com>
Mon, 3 Apr 2023 18:25:31 +0000 (19:25 +0100)
commit75dfbcbfd781f826c73ebe42b78d49c23179d082
tree2e1892adf9901d9dec28533217b4bffcf34a130c
parentfe15c26ee26efa11741a7b632e9f23b01aca4cc6
mailbox: mpfs: fix an incorrect mask width

The system controller registers on PolarFire SoC are 32 bits wide, so
16 + 16 as the first input to GENMASK_ULL() gives a 33 bit wide mask.
It probably should have been immediately obvious when it was pointed
out during review that the width required using GENMASK_ULL() - but I
scarcely knew what I was doing at the time and missed it.
The mistake ends up being moot as it is a mask after all, but it is
incorrect and should be fixed.

No functional change intended.

Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
Tested-by: Valentina Fernandez <valentina.fernandezalanis@microchip.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
drivers/mailbox/mailbox-mpfs.c