]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
tcp: reset sk_rx_dst in tcp_disconnect()
authorWANG Cong <xiyou.wangcong@gmail.com>
Sun, 25 Jun 2017 06:50:30 +0000 (23:50 -0700)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Fri, 11 Aug 2017 10:36:59 +0000 (12:36 +0200)
commit75ec0f5d1b3deaca044b5ae0f57a99409bac7ab8
treed85794fe94a39ed1906dd85104683680d5c51002
parent9f440a302708c02c8d371f32921a23feeaecefdd
tcp: reset sk_rx_dst in tcp_disconnect()

BugLink: http://bugs.launchpad.net/bugs/1705707
commit d747a7a51b00984127a88113cdbbc26f91e9d815 upstream.

We have to reset the sk->sk_rx_dst when we disconnect a TCP
connection, because otherwise when we re-connect it this
dst reference is simply overridden in tcp_finish_connect().

This fixes a dst leak which leads to a loopback dev refcnt
leak. It is a long-standing bug, Kevin reported a very similar
(if not same) bug before. Thanks to Andrei for providing such
a reliable reproducer which greatly narrows down the problem.

Fixes: 41063e9dd119 ("ipv4: Early TCP socket demux.")
Reported-by: Andrei Vagin <avagin@gmail.com>
Reported-by: Kevin Xu <kaiwen.xu@hulu.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
net/ipv4/tcp.c