]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
Yama: access task_struct->comm directly
authorKees Cook <keescook@chromium.org>
Wed, 15 Aug 2012 18:41:55 +0000 (11:41 -0700)
committerJames Morris <james.l.morris@oracle.com>
Fri, 17 Aug 2012 10:40:38 +0000 (20:40 +1000)
commit7612bfeecc197bbb6629842b5c6ff1967f0a9b70
treed73acd2bc97866b256a70acb83e4ca69bce6e32d
parentd9875690d9b89a866022ff49e3fcea892345ad92
Yama: access task_struct->comm directly

The core ptrace access checking routine holds a task lock, and when
reporting a failure, Yama takes a separate task lock. To avoid a
potential deadlock with two ptracers taking the opposite locks, do not
use get_task_comm() and just use ->comm directly since accuracy is not
important for the report.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Suggested-by: Oleg Nesterov <oleg@redhat.com>
CC: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: John Johansen <john.johansen@canonical.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
security/yama/yama_lsm.c