]> git.proxmox.com Git - qemu.git/commit
Fix VNC SASL authentication when using a QXL device
authorChristophe Fergeau <cfergeau@redhat.com>
Wed, 16 Oct 2013 15:52:33 +0000 (17:52 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Thu, 17 Oct 2013 10:25:25 +0000 (12:25 +0200)
commit764eb39d1b6f614e9734ea3ed1b7dcf6c3aaa260
treecbf51eed72a3b0faaca57d9b033577de406b0728
parent26defe81f6a878f33e0aaeb1df4d0d7022c929ca
Fix VNC SASL authentication when using a QXL device

ui/vnc.c:vnc_display_open() and spice-server/server/reds.c:do_spice_init()
are both calling sasl_server_init(). If spice_server_set_sasl_appname()
hasn't been called, spice-server will call it with "spice" as an appname,
causing cyrus-sasl to try to use a /etc/sasl2/spice.conf config file rather
than the /etc/sasl2/qemu.conf file that QEMU uses.

When using -spice sasl on the command line, QEMU properly calls
spice_server_set_sasl_appname() to set the SASL appname as "qemu",
but when using a QXL device without using SPICE, spice_server_init()
is called from qemu_spice_add_interface() without setting the appname
to "qemu", which then causes the VNC code to try to use spice.conf
instead of qemu.conf.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
ui/spice-core.c