]> git.proxmox.com Git - mirror_qemu.git/commit
savevm: Ignore minimum_version_id_old if there is no load_state_old
authorPeter Maydell <peter.maydell@linaro.org>
Thu, 3 Apr 2014 16:52:28 +0000 (19:52 +0300)
committerJuan Quintela <quintela@redhat.com>
Mon, 5 May 2014 20:15:03 +0000 (22:15 +0200)
commit767adce2d9cd397de3418caa16be35ea18d56f22
tree4eade8cd00e2106dadb52e979bbb940304ea1bce
parent9f8e9895c504149d7048e9fc5eb5cbb34b16e49a
savevm: Ignore minimum_version_id_old if there is no load_state_old

At the moment we require vmstate definitions to set minimum_version_id_old
to the same value as minimum_version_id if they do not provide a
load_state_old handler. Since the load_state_old functionality is
required only for a handful of devices that need to retain migration
compatibility with a pre-vmstate implementation, this means the bulk
of devices have pointless boilerplate. Relax the definition so that
minimum_version_id_old is ignored if there is no load_state_old handler.

Note that under the old scheme we would segfault if the vmstate
specified a minimum_version_id_old that was less than minimum_version_id
but did not provide a load_state_old function, and the incoming state
specified a version number between minimum_version_id_old and
minimum_version_id. Under the new scheme this will just result in
our failing the migration.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
docs/migration.txt
vmstate.c