]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
sched/fair: Fix kernel build warning in test_idle_cores() for !SMT NUMA
authorValentin Schneider <valentin.schneider@arm.com>
Tue, 3 Mar 2020 11:02:57 +0000 (11:02 +0000)
committerIngo Molnar <mingo@kernel.org>
Fri, 6 Mar 2020 11:57:22 +0000 (12:57 +0100)
commit76c389ab2b5e300698eab87f9d4b7916f14117ba
tree6574a89da9fa2bc0872f8e548442168ca7bb8edf
parent05289b90c2e40ae80f5c70431cd0be4cc8a6038d
sched/fair: Fix kernel build warning in test_idle_cores() for !SMT NUMA

Building against the tip/sched/core as ff7db0bf24db ("sched/numa: Prefer
using an idle CPU as a migration target instead of comparing tasks") with
the arm64 defconfig (which doesn't have CONFIG_SCHED_SMT set) leads to:

  kernel/sched/fair.c:1525:20: warning: 'test_idle_cores' declared 'static' but never defined [-Wunused-function]
   static inline bool test_idle_cores(int cpu, bool def);
      ^~~~~~~~~~~~~~~

Rather than define it in its own CONFIG_SCHED_SMT #define island, bunch it
up with test_idle_cores().

Reported-by: Anshuman Khandual <anshuman.khandual@arm.com>
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
[mgorman@techsingularity.net: Edit changelog, minor style change]
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Fixes: ff7db0bf24db ("sched/numa: Prefer using an idle CPU as a migration target instead of comparing tasks")
Link: https://lkml.kernel.org/r/20200303110258.1092-3-mgorman@techsingularity.net
kernel/sched/fair.c