]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
bpf, sched: Remove unneeded rcu_read_lock() around BPF program invocation
authorToke Høiland-Jørgensen <toke@redhat.com>
Thu, 24 Jun 2021 16:05:56 +0000 (18:05 +0200)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 24 Jun 2021 17:43:11 +0000 (19:43 +0200)
commit77151ccf10659d4066074f278402032f3265f0cc
tree0e91b4e0e041da86beb85813ee2fa49e8ab497c0
parent782347b6bcad07ddb574422e01e22c92e05928c8
bpf, sched: Remove unneeded rcu_read_lock() around BPF program invocation

The rcu_read_lock() call in cls_bpf and act_bpf are redundant: on the TX
side, there's already a call to rcu_read_lock_bh() in __dev_queue_xmit(),
and on RX there's a covering rcu_read_lock() in
netif_receive_skb{,_list}_internal().

With the previous patches we also amended the lockdep checks in the map
code to not require any particular RCU flavour, so we can just get rid of
the rcu_read_lock()s.

Suggested-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20210624160609.292325-7-toke@redhat.com
net/sched/act_bpf.c
net/sched/cls_bpf.c