]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
splice: only read in as much information as there is pipe buffer space
authorDarrick J. Wong <darrick.wong@oracle.com>
Tue, 15 Oct 2019 15:44:32 +0000 (08:44 -0700)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:23:06 +0000 (14:23 -0300)
commit7736c2a34dd82b800bb0933c9f1b9b71b68683b5
tree88052f46c918bf5cd21080ed535d91bc972fa4e5
parentbe2063280b82447253c4b91d20b57c25f0a26579
splice: only read in as much information as there is pipe buffer space

BugLink: https://bugs.launchpad.net/bugs/1857158
commit 3253d9d093376d62b4a56e609f15d2ec5085ac73 upstream.

Andreas Grünbacher reports that on the two filesystems that support
iomap directio, it's possible for splice() to return -EAGAIN (instead of
a short splice) if the pipe being written to has less space available in
its pipe buffers than the length supplied by the calling process.

Months ago we fixed splice_direct_to_actor to clamp the length of the
read request to the size of the splice pipe.  Do the same to do_splice.

Fixes: 17614445576b6 ("splice: don't read more than available pipe space")
Reported-by: syzbot+3c01db6025f26530cf8d@syzkaller.appspotmail.com
Reported-by: Andreas Grünbacher <andreas.gruenbacher@gmail.com>
Reviewed-by: Andreas Grünbacher <andreas.gruenbacher@gmail.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
fs/splice.c