]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
NFSv4: Fix a dentry leak on alias use
authorBenjamin Coddington <bcodding@redhat.com>
Wed, 17 Feb 2016 15:41:41 +0000 (10:41 -0500)
committerTim Gardner <tim.gardner@canonical.com>
Wed, 6 Apr 2016 09:24:06 +0000 (10:24 +0100)
commit773b3313dd5bfe4fd2ec2b1509ff3db752bbcb6e
treec3cae140a7c3d8c902a9a7dbf49aa73c0d4501b0
parent085262ce150a8cc517125e2db1575d41a6b5662c
NFSv4: Fix a dentry leak on alias use

BugLink: http://bugs.launchpad.net/bugs/1553179
commit d9dfd8d741683347ee159d25f5b50c346a0df557 upstream.

In the case where d_add_unique() finds an appropriate alias to use it will
have already incremented the reference count.  An additional dget() to swap
the open context's dentry is unnecessary and will leak a reference.

Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Fixes: 275bb307865a3 ("NFSv4: Move dentry instantiation into the NFSv4-...")
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
fs/nfs/nfs4proc.c