]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
ftrace/x86: Tell objtool to ignore nondeterministic ftrace stack layout
authorJosh Poimboeuf <jpoimboe@redhat.com>
Fri, 8 Nov 2019 22:51:00 +0000 (16:51 -0600)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Wed, 13 Nov 2019 14:36:50 +0000 (09:36 -0500)
commit77ac117b3a82251b109ffc5daf7d1c5392734be3
tree2ece11020db1a9ad22aad0ea14c718e5a15519e5
parenta3ad1a7e39689005cb04a4f2adb82f9d55b4724f
ftrace/x86: Tell objtool to ignore nondeterministic ftrace stack layout

Objtool complains about the new ftrace direct trampoline code:

  arch/x86/kernel/ftrace_64.o: warning: objtool: ftrace_regs_caller()+0x190: stack state mismatch: cfa1=7+16 cfa2=7+24

Typically, code has a deterministic stack layout, such that at a given
instruction address, the stack frame size is always the same.

That's not the case for the new ftrace_regs_caller() code after it
adjusts the stack for the direct case.  Just plead ignorance and assume
it's always the non-direct path.  Note this creates a tiny window for
ORC to get confused.

Link: http://lkml.kernel.org/r/20191108225100.ea3bhsbdf6oerj6g@treble
Reported-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
arch/x86/include/asm/unwind_hints.h
arch/x86/kernel/ftrace_64.S