]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
net: Fix data-races around sysctl_[rw]mem(_offset)?.
authorKuniyuki Iwashima <kuniyu@amazon.com>
Fri, 22 Jul 2022 18:22:00 +0000 (11:22 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 16 Sep 2022 08:53:45 +0000 (10:53 +0200)
commit77d66f560c54f30895c6b0c1401bcecd38affd2a
treecc77fe8924a78cf0c028ec5f1406bd9e646cccd9
parentef5e550bafd30aa736240775fedddf9fe4af9ef2
net: Fix data-races around sysctl_[rw]mem(_offset)?.

BugLink: https://bugs.launchpad.net/bugs/1989218
[ Upstream commit 02739545951ad4c1215160db7fbf9b7a918d3c0b ]

While reading these sysctl variables, they can be changed concurrently.
Thus, we need to add READ_ONCE() to their readers.

  - .sysctl_rmem
  - .sysctl_rwmem
  - .sysctl_rmem_offset
  - .sysctl_wmem_offset
  - sysctl_tcp_rmem[1, 2]
  - sysctl_tcp_wmem[1, 2]
  - sysctl_decnet_rmem[1]
  - sysctl_decnet_wmem[1]
  - sysctl_tipc_rmem[1]

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
include/net/sock.h
net/decnet/af_decnet.c
net/ipv4/tcp.c
net/ipv4/tcp_input.c
net/ipv4/tcp_output.c
net/mptcp/protocol.c
net/tipc/socket.c