]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
bcm2835-v4l2: Fix buffer overflow problem
authorDave Stevenson <dave.stevenson@raspberrypi.org>
Fri, 10 Mar 2017 14:43:15 +0000 (14:43 +0000)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 14 Jun 2017 09:11:35 +0000 (11:11 +0200)
commit78292fd848cf0991bd7584c5087b98acaae19117
tree54e0ae882997e6106e41686d2589bafb3e146646
parent436d28637a674dd1c5ad2a1cf1dd8deeadbddd44
bcm2835-v4l2: Fix buffer overflow problem

https://github.com/raspberrypi/linux/issues/1447
port_parameter_get() failed to account for the header
(u32 id and u32 size) in the size before memcpying
the response into the response buffer, so overrunning
the provided buffer by 8 bytes.

Account for those bytes, and also a belt-and-braces
check to ensure we never copy more than *value_size
bytes into value.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/media/platform/bcm2835/mmal-vchiq.c