]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/nouveau: fix missing break in switch statement
authorColin Ian King <colin.king@canonical.com>
Mon, 8 Oct 2018 20:47:36 +0000 (21:47 +0100)
committerBen Skeggs <bskeggs@redhat.com>
Tue, 19 Feb 2019 22:59:58 +0000 (08:59 +1000)
commit785cf1eeafa23ec63f426d322401054d13abe2a3
tree33a79a780c9fc0423d8bd6534939514fb6201d19
parent966b2217d2b94ef44c55184f99a40d48f9ad593b
drm/nouveau: fix missing break in switch statement

The NOUVEAU_GETPARAM_PCI_DEVICE case is missing a break statement and falls
through to the following NOUVEAU_GETPARAM_BUS_TYPE case and may end up
re-assigning the getparam->value to an undesired value. Fix this by adding
in the missing break.

Detected by CoverityScan, CID#1460507 ("Missing break in switch")

Fixes: 359088d5b8ec ("drm/nouveau: remove trivial cases of nvxx_device() usage")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
drivers/gpu/drm/nouveau/nouveau_abi16.c