]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
sfc: null out channel->rps_flow_id after freeing it
authorEdward Cree <ecree@solarflare.com>
Tue, 18 Aug 2020 12:44:18 +0000 (13:44 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Aug 2020 19:49:12 +0000 (12:49 -0700)
commit788f920a0f137baa4dbc1efdd5039c4a0a01b8d7
tree90ea280adcddc85db7f3ead28d589aa16cda6425
parent9cbbc451098ec1e9942886023203b2247dec94bd
sfc: null out channel->rps_flow_id after freeing it

If an ef100_net_open() fails, ef100_net_stop() may be called without
 channel->rps_flow_id having been written; thus it may hold the address
 freed by a previous ef100_net_stop()'s call to efx_remove_filters().
 This then causes a double-free when efx_remove_filters() is called
 again, leading to a panic.
To prevent this, after freeing it, overwrite it with NULL.

Fixes: a9dc3d5612ce ("sfc_ef100: RX filter table management and related gubbins")
Signed-off-by: Edward Cree <ecree@solarflare.com>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/rx_common.c