]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
firmware_loader: Fix memory leak in firmware upload
authorRuss Weight <russell.h.weight@intel.com>
Wed, 31 Aug 2022 00:25:18 +0000 (17:25 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 Sep 2022 15:47:27 +0000 (17:47 +0200)
commit789bba82f63c3e81dce426ba457fc7905b30ac6e
treeac7efbdb2aa65d3e69044fb646951ed63829f974
parent8b40c38e37492b5bdf8e95b46b5cca9517a9957a
firmware_loader: Fix memory leak in firmware upload

In the case of firmware-upload, an instance of struct fw_upload is
allocated in firmware_upload_register(). This data needs to be freed
in fw_dev_release(). Create a new fw_upload_free() function in
sysfs_upload.c to handle the firmware-upload specific memory frees
and incorporate the missing kfree call for the fw_upload structure.

Fixes: 97730bbb242c ("firmware_loader: Add firmware-upload support")
Cc: stable <stable@kernel.org>
Signed-off-by: Russ Weight <russell.h.weight@intel.com>
Link: https://lore.kernel.org/r/20220831002518.465274-1-russell.h.weight@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/firmware_loader/sysfs.c
drivers/base/firmware_loader/sysfs.h
drivers/base/firmware_loader/sysfs_upload.c