]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ASoC: rockchip: Fix mono capture
authorCheng-Yi Chiang <cychiang@chromium.org>
Fri, 26 Jul 2019 04:42:02 +0000 (12:42 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 26 Jul 2019 12:09:31 +0000 (13:09 +0100)
commit789e162a6255325325bd321ab0cd51dc7e285054
tree4185438d5b16511df99fe11348a3d910715e57ba
parente51b69808b7ec06fc61f5a332f338d94b64b0537
ASoC: rockchip: Fix mono capture

This reverts commit db51707b9c9aeedd310ebce60f15d5bb006567e0.
Revert "ASoC: rockchip: i2s: Support mono capture"

Previous discussion in

https://patchwork.kernel.org/patch/10147153/

explains the issue of the patch.
While device is configured as 1-ch, hardware is still
generating a 2-ch stream.
When user space reads the data and assumes it is a 1-ch stream,
the rate will be slower by 2x.

Revert the change so 1-ch is not supported.
User space can selectively take one channel data out of two channel
if 1-ch is preferred.
Currently, both channels record identical data.

Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
Link: https://lore.kernel.org/r/20190726044202.26866-1-cychiang@chromium.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/rockchip/rockchip_i2s.c