]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
nvme-multipath: drop optimization for static ANA group IDs
authorHannes Reinecke <hare@suse.de>
Wed, 9 Jan 2019 08:45:15 +0000 (09:45 +0100)
committerJens Axboe <axboe@kernel.dk>
Thu, 24 Jan 2019 00:16:59 +0000 (17:16 -0700)
commit78a61cd42a64f3587862b372a79e1d6aaf131fd7
treeeb9798c79413a79c645b16340f0951e4ce711760
parent5cbab6303b4791a3e6713dfe2c5fda6a867f9adc
nvme-multipath: drop optimization for static ANA group IDs

Bit 6 in the ANACAP field is used to indicate that the ANA group ID
doesn't change while the namespace is attached to the controller.
There is an optimisation in the code to only allocate space
for the ANA group header, as the namespace list won't change and
hence would not need to be refreshed.
However, this optimisation was never carried over to the actual
workflow, which always assumes that the buffer is large enough
to hold the ANA header _and_ the namespace list.
So drop this optimisation and always allocate enough space.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/nvme/host/multipath.c