]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
8021q: fix a memory leak for VLAN 0 device
authorCong Wang <xiyou.wangcong@gmail.com>
Tue, 9 Jan 2018 21:40:41 +0000 (13:40 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 10 Jan 2018 20:31:07 +0000 (15:31 -0500)
commit78bbb15f2239bc8e663aa20bbe1987c91a0b75f6
tree3ec70d00ed6f9afcbe11b0ca67bae4bb5656ebf0
parent6ade262b77f4285f7ba9216d5831093d7766304a
8021q: fix a memory leak for VLAN 0 device

A vlan device with vid 0 is allow to creat by not able to be fully
cleaned up by unregister_vlan_dev() which checks for vlan_id!=0.

Also, VLAN 0 is probably not a valid number and it is kinda
"reserved" for HW accelerating devices, but it is probably too
late to reject it from creation even if makes sense. Instead,
just remove the check in unregister_vlan_dev().

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Fixes: ad1afb003939 ("vlan_dev: VLAN 0 should be treated as "no vlan tag" (802.1p packet)")
Cc: Vlad Yasevich <vyasevich@gmail.com>
Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/8021q/vlan.c