]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
HID: core: Avoid uninitialized buffer access
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 18 Sep 2015 23:31:33 +0000 (16:31 -0700)
committerJiri Kosina <jkosina@suse.cz>
Wed, 23 Sep 2015 12:08:35 +0000 (14:08 +0200)
commit79b568b9d0c7c5d81932f4486d50b38efdd6da6d
tree4b32fb032a341706cde7f365485837dee1c78c34
parent9fe8eccad4425fd024516fac2ebc0a39610441a0
HID: core: Avoid uninitialized buffer access

hid_connect adds various strings to the buffer but they're all
conditional. You can find circumstances where nothing would be written
to it but the kernel will still print the supposedly empty buffer with
printk. This leads to corruption on the console/in the logs.

Ensure buf is initialized to an empty string.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
[dvhart: Initialize string to "" rather than assign buf[0] = NULL;]
Cc: Jiri Kosina <jikos@kernel.org>
Cc: linux-input@vger.kernel.org
Cc: stable@vger.kernel.org
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-core.c