]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
iio: ad7768-1: Call iio_trigger_notify_done() on error
authorLars-Peter Clausen <lars@metafoo.de>
Mon, 1 Nov 2021 14:40:55 +0000 (15:40 +0100)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 4 Jan 2022 08:49:19 +0000 (09:49 +0100)
commit7a5927dbec39eb3c4e2c8542582918ba6707c155
treebb90d21a930dc59b6852c1b9c53073d92f14604e
parentc87e1967f5af8ae4c6a38d94d565d9f6d52c50bb
iio: ad7768-1: Call iio_trigger_notify_done() on error

BugLink: https://bugs.launchpad.net/bugs/1954931
commit 6661146427cbbce6d1fe3dbb11ff1c487f55799a upstream.

IIO trigger handlers must call iio_trigger_notify_done() when done. This
must be done even when an error occurred. Otherwise the trigger will be
seen as busy indefinitely and the trigger handler will never be called
again.

The ad7768-1 driver neglects to call iio_trigger_notify_done() when there
is an error reading the converter data. Fix this by making sure that
iio_trigger_notify_done() is included in the error exit path.

Fixes: a5f8c7da3dbe ("iio: adc: Add AD7768-1 ADC basic support")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20211101144055.13858-2-lars@metafoo.de
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/iio/adc/ad7768-1.c