]> git.proxmox.com Git - qemu.git/commit
switch raw block driver from "raw.o" to "raw_bsd.o"
authorLaszlo Ersek <lersek@redhat.com>
Wed, 21 Aug 2013 10:41:23 +0000 (12:41 +0200)
committerKevin Wolf <kwolf@redhat.com>
Fri, 30 Aug 2013 13:28:52 +0000 (15:28 +0200)
commit7a6d3fc594d1166ec78a6b74ba76753078de0de5
tree2a01d5d7d6f48959ffaa9d9565e7301e5e0a8274
parent775d6afd5cd66f2154a81f5de9d3dd7297a35072
switch raw block driver from "raw.o" to "raw_bsd.o"

"Incoming" function prototypes and "outgoing" function calls must match
reality. Implemented using the "struct BlockDriver" definition in
"include/block/block_int.h", and gcc errors & warnings.

v1->v2:

On 08/20/13 09:51, Kevin Wolf wrote:
> Am 18.08.2013 um 16:29 hat Paolo Bonzini geschrieben:
>> Il 16/08/2013 16:15, Laszlo Ersek ha scritto:
>>> +static int raw_reopen_prepare(BDRVReopenState *reopen_state,
>>> +                              BlockReopenQueue *queue, Error **errp)
>>>  {
>>> -    return bdrv_reopen_prepare(bs->file);
>>> +    BDRVReopenState tmp = *reopen_state;
>>> +
>>> +    tmp.bs = tmp.bs->file;
>>> +    return bdrv_reopen_prepare(&tmp, queue, errp);
>>>  }
>>
>> This should just return zero, my fault.
>
> Which is because bdrv_reopen_queue() already queues bs->file for reopen.
> The simple return 0; implementation is shared by all other format drivers
> that support reopening images.

Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/Makefile.objs
block/raw_bsd.c