]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net/mlx5e: Check netdev pointer before checking its net ns
authorGavin Li <gavinl@nvidia.com>
Thu, 31 Aug 2023 02:47:09 +0000 (05:47 +0300)
committerSaeed Mahameed <saeedm@nvidia.com>
Tue, 5 Dec 2023 06:11:53 +0000 (22:11 -0800)
commit7aaf975238c47b710fcc4eca0da1e7902a53abe2
treeb5b005db101c796728b00aeafa5be7601dd901d2
parent3d7a3f2612d75de5f371a681038b089ded6667eb
net/mlx5e: Check netdev pointer before checking its net ns

Previously, when comparing the net namespaces, the case where the netdev
doesn't exist wasn't taken into account, and therefore can cause a crash.
In such a case, the comparing function should return false, as there is no
netdev->net to compare the devlink->net to.

Furthermore, this will result in an attempt to enter switchdev mode
without a netdev to fail, and which is the desired result as there is no
meaning in switchdev mode without a net device.

Fixes: 662404b24a4c ("net/mlx5e: Block entering switchdev mode with ns inconsistency")
Signed-off-by: Gavin Li <gavinl@nvidia.com>
Reviewed-by: Gavi Teitz <gavi@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c