]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
cfg80211: wext does not need to set monitor channel in managed mode
authorJorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Mon, 9 Jan 2017 14:25:49 +0000 (15:25 +0100)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 11 Jan 2017 13:10:44 +0000 (14:10 +0100)
commit7acec26cec5aa75e0dc54da1fb0b1f8acf575273
tree183314cefd388b89c7729cac25462a533ab184ca
parentbd2522b168847106c1885f0319a2833bdf88bf9a
cfg80211: wext does not need to set monitor channel in managed mode

There is not a valid reason to attempt setting the monitor channel
while in managed mode. Since this code path only deals with this mode,
remove the code block.

Johannes: I'll note that the comment indicated it was for backward
compatibility, but the code wasn't functional since switching the
monitor channel isn't supported (any more?) when in managed mode, as
that mode owns the channel configuration. Additionally, since monitor
can't be done on a managed mode interface, this would only have had
any effect to start with if a separate monitor interface is present,
in which case it's better to change the channel through that anyway,
if even possible.

Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/wireless/wext-sme.c