]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
RDMA/irdma: Prevent some integer underflows
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 7 Mar 2022 12:59:28 +0000 (15:59 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 12:39:10 +0000 (14:39 +0200)
commit7b03639d77fcd1d2499692740cb3b45a9d78bea8
treed400e9a853775cec335e702feef1cb5801751bd3
parent64f5c7b870d00828085c9a89920780044bdcfaca
RDMA/irdma: Prevent some integer underflows

BugLink: https://bugs.launchpad.net/bugs/1969110
[ Upstream commit 6f6dbb819dfc1a35bcb8b709b5c83a3ea8beff75 ]

My static checker complains that:

    drivers/infiniband/hw/irdma/ctrl.c:3605 irdma_sc_ceq_init()
    warn: can subtract underflow 'info->dev->hmc_fpm_misc.max_ceqs'?

It appears that "info->dev->hmc_fpm_misc.max_ceqs" comes from the firmware
in irdma_sc_parse_fpm_query_buf() so, yes, there is a chance that it could
be zero.  Even if we trust the firmware, it's easy enough to change the
condition just as a hardenning measure.

Fixes: 3f49d6842569 ("RDMA/irdma: Implement HW Admin Queue OPs")
Link: https://lore.kernel.org/r/20220307125928.GE16710@kili
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit d52dab6e03550f9c97121b0c11c0a3ed78ee76a4)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/infiniband/hw/irdma/ctrl.c