]> git.proxmox.com Git - mirror_qemu.git/commit
hw/microblaze/xlnx-zynqmp-pmu: Fix introspection problem in 'xlnx, zynqmp-pmu-soc'
authorThomas Huth <thuth@redhat.com>
Mon, 23 Jul 2018 14:21:25 +0000 (15:21 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 23 Jul 2018 14:21:25 +0000 (15:21 +0100)
commit7b6d7b84da328d5d1fffb862b8388d511e085812
treee34852e30f46aefcde5d6520af70f41334102d71
parent55b1f14cefcb19ce6d5e28c4c83404230888aa7e
hw/microblaze/xlnx-zynqmp-pmu: Fix introspection problem in 'xlnx, zynqmp-pmu-soc'

Valgrind complains:

echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \
 "'arguments':{'typename':'xlnx,zynqmp-pmu-soc'}}" \
 "{'execute': 'human-monitor-command', " \
 "'arguments': {'command-line': 'info qtree'}}" | \
 valgrind -q microblazeel-softmmu/qemu-system-microblazeel -M none,accel=qtest -qmp stdio
[...]
==13605== Invalid read of size 8
==13605==    at 0x2AC69A: qdev_print (qdev-monitor.c:686)
==13605==    by 0x2AC69A: qbus_print (qdev-monitor.c:719)
==13605==    by 0x2591E8: handle_hmp_command (monitor.c:3446)

Use the new object_initialize_child() and sysbus_init_child_obj() to
fix the issue.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Message-id: 1531839343-13828-1-git-send-email-thuth@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/microblaze/xlnx-zynqmp-pmu.c