]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
drm/i915: Enable hotplug interrupts after querying hw capabilities.
authorChris Wilson <chris@chris-wilson.co.uk>
Sun, 9 Jun 2013 15:02:04 +0000 (16:02 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 10 Jun 2013 07:59:26 +0000 (09:59 +0200)
commit7ba220cec0bbe9453c1f958cf282f84a157c924f
tree8e7099fd13ba1f0b11f70f615b237876727d73ed
parent7ee2aff373498a887cde0d564f89cf05377c538e
drm/i915: Enable hotplug interrupts after querying hw capabilities.

sdvo->hotplug_active is initialised during intel_sdvo_setup_outputs(),
and so we never enabled the hotplug interrupts on SDVO as we were
checking too early.

This regression has been introduced somewhere in the hpd rework for
the storm detection and handling starting with

commit 1d843f9de4e6dc6a899b6f07f106c00da09925e6
Author: Egbert Eich <eich@suse.de>
Date:   Mon Feb 25 12:06:49 2013 -0500

    DRM/I915: Add enum hpd_pin to intel_encoder.

and the follow-up patches to use the new encoder->hpd_pin variable for
the different irq setup functions.

The problem is that encoder->hpd_pin was set up _before_ the output
setup was done and so before we could assess the hotplug capabilities
of the outputs on an sdvo encoder.

Reported-by: Alex Fiestas <afiestas@kde.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=58405
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
[danvet: Add regression note.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_sdvo.c