]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
scsi: megaraid: Fix error check return value of register_chrdev()
authorLv Ruyi <lv.ruyi@zte.com.cn>
Mon, 18 Apr 2022 10:57:55 +0000 (10:57 +0000)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 10 Aug 2022 07:23:42 +0000 (09:23 +0200)
commit7c0c4d57e74c6c41c35f0c5a71687cb5ebdcb9e3
treeb30208fd3550b4eb2800c9ecc02b67f9409c9212
parentcba24348c8975cf9308b4ffb83289d2a345e2496
scsi: megaraid: Fix error check return value of register_chrdev()

BugLink: https://bugs.launchpad.net/bugs/1981864
[ Upstream commit c5acd61dbb32b6bda0f3a354108f2b8dcb788985 ]

If major equals 0, register_chrdev() returns an error code when it fails.
This function dynamically allocates a major and returns its number on
success, so we should use "< 0" to check it instead of "!".

Link: https://lore.kernel.org/r/20220418105755.2558828-1-lv.ruyi@zte.com.cn
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/scsi/megaraid.c