]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
jffs2: validate symlink size in jffs2_do_read_inode_internal()
authorXi Wang <xi.wang@gmail.com>
Wed, 25 Apr 2012 18:45:22 +0000 (14:45 -0400)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Mon, 14 May 2012 04:05:15 +0000 (23:05 -0500)
commit7c80c352331a27cf0584f1701ed3a003984985f0
tree3c90b8d5a23cf563fb40a9866bc8dcf11af4b2fc
parent8abc0d4a1181b44e0a42cadab4a15f8c6aa42451
jffs2: validate symlink size in jffs2_do_read_inode_internal()

`csize' is read from disk and thus needs validation.  Otherwise a bogus
value 0xffffffff would turn the subsequent kmalloc(csize + 1, ...) into
kmalloc(0, ...), leading to out-of-bounds write.

This patch limits `csize' to JFFS2_MAX_NAME_LEN, which is also used
in jffs2_symlink().

Artem: we actually validate csize by checking CRC, so this 0xFFs cannot
come from empty flash region. But I guess an attacker could feed JFFS2
an image with random csize value, including 0xFFs.

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
fs/jffs2/readinode.c