]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ASoC: SOF: amd: Move group register configuration to acp-loader
authorAjit Kumar Pandey <AjitKumar.Pandey@amd.com>
Fri, 4 Mar 2022 20:57:29 +0000 (14:57 -0600)
committerMark Brown <broonie@kernel.org>
Mon, 7 Mar 2022 13:12:50 +0000 (13:12 +0000)
commit7cf467ac9cf33f0975095f080a79f6ec6d9be5b6
tree928703561d5923b14be7093564f6b19ab949e8b0
parentdc0d4ed26dd2166b47c29d6a9829ac798e62a0fc
ASoC: SOF: amd: Move group register configuration to acp-loader

We are using PTE_GRP1 for DMA operations to load firmware binaries
but we are enabling PTE_GRP and flushing ATU cache much before in
probe callbacks. This can cause issue if we try to load firmware
runtime during system resume as probe callback will not be invoked
hence PTE_GRP will not be enabled. Moreover it makes more sense to
flush the cache after register configuration.

Move PTE group register configuration to acp-loader within pre_fw_run
callback to avoid such issue.

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220304205733.62233-7-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/amd/acp-loader.c
sound/soc/sof/amd/acp.c