]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
staging: android: ashmem: Fix mmap size validation
authorAlistair Strachan <astrachan@google.com>
Wed, 20 Jun 2018 00:57:35 +0000 (17:57 -0700)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:50:57 +0000 (19:50 -0600)
commit7d60aac2213f7b0c47be91719c0d5dd53e82ff58
tree5627f1510b7112102e88a894d6d9160cde31740a
parentcf4335e61ea2a025ea8ee41bc3d55e5dff206b3b
staging: android: ashmem: Fix mmap size validation

BugLink: https://bugs.launchpad.net/bugs/1836287
[ Upstream commit 8632c614565d0c5fdde527889601c018e97b6384 ]

The ashmem driver did not check that the size/offset of the vma passed
to its .mmap() function was not larger than the ashmem object being
mapped. This could cause mmap() to succeed, even though accessing parts
of the mapping would later fail with a segmentation fault.

Ensure an error is returned by the ashmem_mmap() function if the vma
size is larger than the ashmem object size. This enables safer handling
of the problem in userspace.

Cc: Todd Kjos <tkjos@android.com>
Cc: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org
Cc: kernel-team@android.com
Cc: Joel Fernandes <joel@joelfernandes.org>
Signed-off-by: Alistair Strachan <astrachan@google.com>
Acked-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Reviewed-by: Martijn Coenen <maco@android.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/staging/android/ashmem.c