]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
media: uvcvideo: fix division by zero at stream start
authorJohan Hovold <johan@kernel.org>
Tue, 26 Oct 2021 09:55:11 +0000 (11:55 +0200)
committerPaolo Pisati <paolo.pisati@canonical.com>
Tue, 25 Jan 2022 11:05:32 +0000 (12:05 +0100)
commit7de460df9e3bcd2671ca4fc258908d8b21e6bdbc
treed9eae2657f7af3b02cdd6fec1aff24e37aadc2e4
parent2e2837fb73bdb68c12e2387c452b74d6dcc5b094
media: uvcvideo: fix division by zero at stream start

BugLink: https://bugs.launchpad.net/bugs/1958977
commit 8aa637bf6d70d2fb2ad4d708d8b9dd02b1c095df upstream.

Add the missing bulk-endpoint max-packet sanity check to
uvc_video_start_transfer() to avoid division by zero in
uvc_alloc_urb_buffers() in case a malicious device has broken
descriptors (or when doing descriptor fuzz testing).

Note that USB core will reject URBs submitted for endpoints with zero
wMaxPacketSize but that drivers doing packet-size calculations still
need to handle this (cf. commit 2548288b4fb0 ("USB: Fix: Don't skip
endpoint descriptors with maxpacket=0")).

Fixes: c0efd232929c ("V4L/DVB (8145a): USB Video Class driver")
Cc: stable@vger.kernel.org # 2.6.26
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/media/usb/uvc/uvc_video.c